chore: add UnifiedOpts.Opts#getHasher() to return a hasher relative to the set of Opts defined for an operation.#3174
Closed
BenWhitehead wants to merge 1 commit intochecksumming/03/default-hasherfrom
Conversation
…o the set of Opts defined for an operation.
Add `UnifiedOpts.HasherSelector` (also add `UnifiedOptions.BucketObjectHmacKeyAllOpt` which extends all ``{Bucket,Object,HmacKey}{Target,List,Source}Opt` and provides an anchor for those opts which apply to all 9 permutations [UserProject & Headers])
Add Opts#getHasher() that will return Hasher.defaultInstance() or a hasher defined based on the last occurring HasherProvider present in the instance of Opts.
Both Crc32cMatch and Md5Match are configured to return Hasher.noop(). If an explicit checksum value is provided by the customer, use it and disable our automatic crc32c calculation.
product-auto-label
bot
added
size: m
cojenco
approved these changes
Jul 9, 2025
Contributor
cojenco
left a comment
cojenco
left a comment
There was a problem hiding this comment.
LGTM, had a GVC review session with Ben
| return DefaultHasherSelector.INSTANCE; | ||
| } | ||
|
|
||
| static final class Crc32cMatch implements ObjectTargetOpt, HasherSelector { |
Contributor
There was a problem hiding this comment.
Very cool! Thanks for walking through the UnifiedOpts interfaces
BenWhitehead
added a commit
that referenced
this pull request
Jul 23, 2025
Merge train for * chore: cleanup Crc32cValue and associated Hasher operations #3167 * chore: add Hasher#defaultHasher() #3173 * chore: add UnifiedOpts.Opts#getHasher() to return a hasher relative to the set of Opts defined for an operation. #3174 * feat: add default end-to-end crc32c checksumming for several upload methods via grpc transport #3176 * feat: add default end-to-end checksumming for JournalingBlobWriteSessionConfig #3180 * fix: give user provided checksum precondition priority for Storage#create methods that accept byte[] #3182 * fix: move crc32c computation before writing to disk for BufferToDiskThenUpload BlobWriteSession config #3187
Collaborator
Author
|
merged in #3197 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
UnifiedOpts.HasherSelector(also addUnifiedOptions.BucketObjectHmacKeyAllOptwhich extends all{Bucket,Object,HmacKey}{Target,List,Source}Optand provides an anchor for those opts which apply to all 9 permutations [UserProject & Headers])Add Opts#getHasher() that will return Hasher.defaultInstance() or a hasher defined based on the last occurring HasherProvider present in the instance of Opts.
Both Crc32cMatch and Md5Match are configured to return Hasher.noop(). If an explicit checksum value is provided by the customer, use it and disable our automatic crc32c calculation.