feat: add new preview Bucket encryption policy configuration#3204
feat: add new preview Bucket encryption policy configuration#3204BenWhitehead merged 2 commits intomainfrom
Conversation
BenWhitehead
commented
Jul 23, 2025
BenWhitehead
commented
- GoogleManagedEncryptionEnforcementConfig
- CustomerManagedEncryptionEnforcementConfig
- CustomerSuppliedEncryptionEnforcementConfig
product-auto-label
bot
added
size: l
* GoogleManagedEncryptionEnforcementConfig * CustomerManagedEncryptionEnforcementConfig * CustomerSuppliedEncryptionEnforcementConfig
BenWhitehead
force-pushed
the
feat/bucket-encryption-config
branch
from
122f35c to
67baf14
Compare
| GoogleManagedEncryptionEnforcementConfig, | ||
| Encryption.GoogleManagedEncryptionEnforcementConfig> | ||
| googleManagedEncryptionEnforcementConfigCodec = | ||
| Codec.of( |
There was a problem hiding this comment.
This stuff seems very boilerplate. I wonder if there's a good way to pare it down or make more in common with the other methods. Probably nothing to do about it just now, so just an observation.
There was a problem hiding this comment.
It is. Unfortunately, the types we are touching are grpc generated and apiary generated classes. Which have the same shape, but none of the shared common class hierarchy. We'd either need what we have here, or some facade that was able to sit over both and make this code easier, but that facade would need to do some translation/mapping itself. So, while not ideal by an abstraction perspective, the conversions classes are at least mostly self contained and low maintenance once the conversions are added.
2 participants
