fix: [#738] The Orm Creating event can be triggered when the query with the Model method

[hwbrzzl]

📑 Description

Closes goravel/goravel#738

This pull request introduces several improvements focused on error handling, resource management, and code readability across the codebase. The most significant changes are the adoption of a new errors.Ignore helper for safely ignoring errors from resource cleanup operations, refactoring conditional logic for clarity, and improving switch statement usage. These updates enhance code reliability and maintainability, especially around file and network resource handling.

Error Handling and Resource Management:

• Introduced the errors.Ignore helper function and replaced direct calls to Close() and similar cleanup methods with errors.Ignore in many places (e.g., file, network, and response closing operations) to prevent unhandled errors during resource cleanup. This affects files such as database/gorm/query.go, filesystem/local.go, support/file/file.go, support/http/body.go, testing/file/file.go, testing/http/test_response.go, tests/container.go, and more. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14]

Code Readability and Logic Simplification:

• Refactored conditional expressions for clarity, such as replacing !(a && b) with !a || !b in database/gorm/event.go and simplifying switch statements to use direct value matching instead of boolean expressions in several locations (mail/mail.go, log/utils.go). [1] [2] [3] [4] [5]
• Improved switch statement usage to use direct value matching rather than boolean expressions, making the code easier to read and maintain, particularly in mail/mail.go and log/utils.go. [1] [2] [3]

Test and Assertion Improvements:

• Updated test assertions from assert.Nil to assert.NoError for better clarity and reliability, and improved temporary file cleanup in test files. [1] [2] [3] [4]

Database Event Handling Enhancements:

• Added helper functions isSlice and hasID to database/gorm/query.go and updated event methods to skip event firing for slices or objects without IDs, improving event system robustness. [1] [2] [3] [4] [5] [6] [7]

Miscellaneous Improvements:

• Used assert.Equal with updated expected values in tests to reflect code changes.
• Used _ = os.Setenv(...) to ignore errors from environment variable setting in build commands.
• Minor improvements to string formatting and indentation logic for better output formatting and code clarity. [1] [2]

These changes collectively improve error resilience, code clarity, and maintainability throughout the project.

✅ Checks

• Added test cases for my code

[codecov]

Codecov Report

❌ Patch coverage is 62.50000% with 15 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (v1.16.x@c236b42). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
mail/mail.go	43.75%	9 Missing ⚠️
console/console/build_command.go	0.00%	3 Missing ⚠️
errors/errors.go	0.00%	2 Missing ⚠️
support/file/file.go	66.66%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             v1.16.x    #1166   +/-   ##
==========================================
  Coverage           ?   66.91%           
==========================================
  Files              ?      215           
  Lines              ?    14081           
  Branches           ?        0           
==========================================
  Hits               ?     9422           
  Misses             ?     4282           
  Partials           ?      377           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Copilot]

Pull Request Overview

This pull request addresses an issue where ORM events were being triggered inappropriately when performing bulk operations or operations on slices/collections. The fix improves event system robustness by preventing events from firing for slices or objects without IDs, and replaces direct resource cleanup calls with an error-ignoring helper throughout the codebase.

• Added helper functions to determine when to skip event firing for bulk operations
• Introduced errors.Ignore helper for consistent resource cleanup error handling
• Improved code readability by simplifying conditional logic and switch statements

Reviewed Changes

Copilot reviewed 28 out of 29 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
database/gorm/query.go	Added helper functions and event skipping logic for bulk operations
tests/query_test.go	Added comprehensive test cases to verify events are not triggered for slice operations
tests/models.go	Added test assertions to catch inappropriate event triggering
errors/errors.go	Added new Ignore helper function for resource cleanup
Multiple files	Replaced direct resource cleanup calls with errors.Ignore wrapper

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[hwbrzzl]

@almas-x defer func seems to be easier?

defer func () {
  _ = f.Close()
}()

[devhaozi]

LGTM

[almas-x]

How about func Ignore(fns ...func()error)?

[hwbrzzl]

If so, I prefer defer func directly. 😂

[almas-x]

The main point is using defer to handle closure functions just to ignore errors, which makes the code look noisy.

[hwbrzzl]

Sure, we can keep Ignore(fn func() error) for now.