Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1168 +/- ##
==========================================
- Coverage 68.60% 68.54% -0.06%
==========================================
Files 223 223
Lines 14475 14475
==========================================
- Hits 9930 9922 -8
- Misses 4169 4178 +9
+ Partials 376 375 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.50.
| Benchmark suite | Current: 744aa12 | Previous: a4a1e40 | Ratio |
|---|---|---|---|
BenchmarkFile_ReadWrite |
264885 ns/op 6258 B/op 99 allocs/op |
174388 ns/op 6258 B/op 99 allocs/op |
1.52 |
BenchmarkFile_ReadWrite - ns/op |
264885 ns/op |
174388 ns/op |
1.52 |
This comment was automatically generated by workflow using github-action-benchmark.
| assert.Contains(t, content, "Version") | ||
| } | ||
|
|
||
| func TestGetFrameworkContent(t *testing.T) { |
There was a problem hiding this comment.
The GetFrameworkContent function is not used actually for now, we can remove it if Go v1.24 doesn't support testing it directly. We can add the tests in goravel/example when implementing goravel/goravel#719
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes the tooling approach by migrating from the traditional Go tools pattern to the new go tool directive introduced in Go 1.21. The change removes the tools.go file and updates the build configuration to use the tool directive.
- Removed the tools.go file that was using the build constraint pattern for managing tools
- Migrated mockery dependency from direct requirement to tool directive in go.mod
- Updated GitHub workflow to use
go tool mockeryinstead ofgo run
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tool.go | Removed the entire tools.go file that managed mockery as a build tool |
| support/file/file_test.go | Removed test function for GetFrameworkContent functionality |
| go.mod | Moved mockery from direct dependency to tool directive and indirect dependency |
| .github/workflows/mockery.yml | Updated workflow to use go tool mockery command |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
2 participants
📑 Description
Closes goravel/goravel#605
We can use
go tool mockeryinstead ofgo run github.com/vektra/mockery/v2.✅ Checks