Skip to content

chore: update environment variable handling in tests and build command#1170

Merged
almas-x merged 1 commit intomasterfrom
almas/chore
Aug 23, 2025
Merged

chore: update environment variable handling in tests and build command#1170
almas-x merged 1 commit intomasterfrom
almas/chore

Conversation

@almas-x
Copy link
Contributor

@almas-x almas-x commented Aug 23, 2025

📑 Description

✅ Checks

  • Added test cases for my code

Copilot AI review requested due to automatic review settings August 23, 2025 04:02
@almas-x almas-x requested a review from a team as a code owner August 23, 2025 04:02

func generateCommand(name string, static bool) []string {
command := []string{"go", "build"}
commands := []string{"go", "build"}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable 'command' collides with imported package name

@almas-x almas-x changed the title Almas/chore chore: update environment variable handling in tests and build command Aug 23, 2025
@codecov
Copy link

codecov bot commented Aug 23, 2025

Codecov Report

❌ Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 68.55%. Comparing base (21f0aed) to head (65118cb).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
console/console/build_command.go 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1170      +/-   ##
==========================================
+ Coverage   68.54%   68.55%   +0.01%     
==========================================
  Files         223      223              
  Lines       14475    14472       -3     
==========================================
  Hits         9922     9922              
+ Misses       4178     4175       -3     
  Partials      375      375              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copy link
Contributor

@hwbrzzl hwbrzzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@almas-x almas-x merged commit b8e3a32 into master Aug 23, 2025
15 of 18 checks passed
@almas-x almas-x deleted the almas/chore branch August 23, 2025 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants