Skip to content

Comments

feat: Add DateTimes method to Blueprint for timestamp columns#1179

Merged
hwbrzzl merged 1 commit intogoravel:masterfrom
BadJacky:master
Sep 3, 2025
Merged

feat: Add DateTimes method to Blueprint for timestamp columns#1179
hwbrzzl merged 1 commit intogoravel:masterfrom
BadJacky:master

Conversation

@BadJacky
Copy link
Contributor

@BadJacky BadJacky commented Sep 2, 2025

  • Add DateTimes method to Blueprint interface
  • Implement DateTimes method to create created_at and updated_at columns
  • Add precision parameter support for timestamp columns
  • Add test coverage for DateTimes functionality

📑 Description

Closes https://github.com/goravel/goravel/issues/

✅ Checks

  • Added test cases for my code

@BadJacky BadJacky requested a review from a team as a code owner September 2, 2025 16:51
@codecov
Copy link

codecov bot commented Sep 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.86%. Comparing base (4a9cc76) to head (e1d3e26).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1179   +/-   ##
=======================================
  Coverage   68.86%   68.86%           
=======================================
  Files         230      230           
  Lines       14879    14879           
=======================================
  Hits        10246    10246           
  Misses       4235     4235           
  Partials      398      398           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@BadJacky BadJacky changed the title feat: add DateTimes method to Blueprint for timestamp columns feat: Add DateTimes method to Blueprint for timestamp columns Sep 2, 2025
@devhaozi

This comment was marked as resolved.

devhaozi
devhaozi previously approved these changes Sep 2, 2025
Copy link
Member

@devhaozi devhaozi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@hwbrzzl hwbrzzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, two nitpicks.

@BadJacky
Copy link
Contributor Author

BadJacky commented Sep 3, 2025

@hwbrzzl Wait for me a moment, there is one point that needs to be reconfirmed.

- Add DateTimes method to Blueprint interface
- Implement DateTimes method to create created_at and updated_at columns
- Add precision parameter support for timestamp columns
- Add test coverage for DateTimes functionality
@BadJacky
Copy link
Contributor Author

BadJacky commented Sep 3, 2025

@hwbrzzl I have already confirmed and resubmitted to ensure there are no mistakes.

Copy link
Contributor

@hwbrzzl hwbrzzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@hwbrzzl hwbrzzl merged commit b8f77af into goravel:master Sep 3, 2025
21 of 22 checks passed
@hwbrzzl
Copy link
Contributor

hwbrzzl commented Sep 3, 2025

Hey @BadJacky Added you to the contributor list, thanks for your contribution. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants