Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1191 +/- ##
==========================================
+ Coverage 68.86% 69.42% +0.55%
==========================================
Files 235 229 -6
Lines 15386 14391 -995
==========================================
- Hits 10596 9991 -605
+ Misses 4406 4044 -362
+ Partials 384 356 -28 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| } | ||
| } | ||
|
|
||
| func TestEnglishIrregularPlurals(t *testing.T) { |
There was a problem hiding this comment.
Move the test cases to avoid import cycle.
| @@ -0,0 +1,29 @@ | |||
| // To avoid import cycle, only be used internally. | |||
|
|
|||
| package internals | |||
There was a problem hiding this comment.
internal can't be used, given it's a keyword in Go.
There was a problem hiding this comment.
Pull Request Overview
This pull request refactors path handling and package management infrastructure, introducing several key improvements to the framework's internal architecture and adding cache facade installation support.
- Consolidates path handling logic into a dedicated internal package to avoid import cycles
- Enhances package installation/uninstallation logic with better dependency management and facade handling
- Introduces cache setup stubs and installation logic for the Cache facade
Reviewed Changes
Copilot reviewed 13 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| support/pluralizer/inflector/inflector_test.go | Moves comprehensive inflection tests from english package to inflector package for better organization |
| support/pluralizer/english/english_test.go | Removes redundant tests that were moved to inflector package, keeping only structure tests |
| support/path/internals/path.go | Creates new internal path handling utilities to avoid import cycles |
| support/path/internals/path_test.go | Adds test coverage for new internal path functions |
| support/convert/convert.go | Minor import formatting improvement |
| packages/modify/modify.go | Updates to use internal path utilities instead of foundation App |
| packages/modify/modify_test.go | Refactors tests to remove foundation mocking dependencies and use direct path construction |
| foundation/console/package_uninstall_command.go | Enhances uninstall logic with better dependency tracking and facade existence checks |
| foundation/console/package_uninstall_command_test.go | Adds comprehensive test coverage for new uninstall functionality |
| foundation/application.go | Refactors to use internal path utilities and adds console service provider to base providers |
| console/service_provider.go | Minor formatting improvement in service provider |
| cache/setup/stubs.go | Introduces stub templates for cache configuration and facade setup |
| cache/setup/setup.go | Implements cache package installation/uninstallation logic with facade support |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
* feat: install Cache facade * add tests
📑 Description
Related goravel/goravel#423
This pull request refactors internal path handling in the framework, improves package installation/uninstallation logic, and introduces stubs for cache setup. The changes help decouple path logic, enhance the reliability of facade management, and streamline the setup process for cache-related files. Below are the most important changes grouped by theme:
✅ Checks