Skip to content

Comments

feat: install Cache facade#1191

Merged
hwbrzzl merged 2 commits intomasterfrom
bowen/install-cache
Sep 12, 2025
Merged

feat: install Cache facade#1191
hwbrzzl merged 2 commits intomasterfrom
bowen/install-cache

Conversation

@hwbrzzl
Copy link
Contributor

@hwbrzzl hwbrzzl commented Sep 11, 2025

📑 Description

Related goravel/goravel#423

This pull request refactors internal path handling in the framework, improves package installation/uninstallation logic, and introduces stubs for cache setup. The changes help decouple path logic, enhance the reliability of facade management, and streamline the setup process for cache-related files. Below are the most important changes grouped by theme:

image

✅ Checks

  • Added test cases for my code

@codecov
Copy link

codecov bot commented Sep 11, 2025

Codecov Report

❌ Patch coverage is 46.55172% with 31 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.42%. Comparing base (123d53e) to head (2304370).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
cache/setup/stubs.go 0.00% 15 Missing ⚠️
cache/setup/setup.go 0.00% 10 Missing ⚠️
support/path/internals/path.go 78.57% 2 Missing and 1 partial ⚠️
foundation/console/package_uninstall_command.go 88.23% 1 Missing and 1 partial ⚠️
console/service_provider.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1191      +/-   ##
==========================================
+ Coverage   68.86%   69.42%   +0.55%     
==========================================
  Files         235      229       -6     
  Lines       15386    14391     -995     
==========================================
- Hits        10596     9991     -605     
+ Misses       4406     4044     -362     
+ Partials      384      356      -28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

}
}

func TestEnglishIrregularPlurals(t *testing.T) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move the test cases to avoid import cycle.

@@ -0,0 +1,29 @@
// To avoid import cycle, only be used internally.

package internals
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

internal can't be used, given it's a keyword in Go.

@hwbrzzl hwbrzzl marked this pull request as ready for review September 11, 2025 13:57
@hwbrzzl hwbrzzl requested a review from a team as a code owner September 11, 2025 13:57
Copilot AI review requested due to automatic review settings September 11, 2025 13:57
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request refactors path handling and package management infrastructure, introducing several key improvements to the framework's internal architecture and adding cache facade installation support.

  • Consolidates path handling logic into a dedicated internal package to avoid import cycles
  • Enhances package installation/uninstallation logic with better dependency management and facade handling
  • Introduces cache setup stubs and installation logic for the Cache facade

Reviewed Changes

Copilot reviewed 13 out of 14 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
support/pluralizer/inflector/inflector_test.go Moves comprehensive inflection tests from english package to inflector package for better organization
support/pluralizer/english/english_test.go Removes redundant tests that were moved to inflector package, keeping only structure tests
support/path/internals/path.go Creates new internal path handling utilities to avoid import cycles
support/path/internals/path_test.go Adds test coverage for new internal path functions
support/convert/convert.go Minor import formatting improvement
packages/modify/modify.go Updates to use internal path utilities instead of foundation App
packages/modify/modify_test.go Refactors tests to remove foundation mocking dependencies and use direct path construction
foundation/console/package_uninstall_command.go Enhances uninstall logic with better dependency tracking and facade existence checks
foundation/console/package_uninstall_command_test.go Adds comprehensive test coverage for new uninstall functionality
foundation/application.go Refactors to use internal path utilities and adds console service provider to base providers
console/service_provider.go Minor formatting improvement in service provider
cache/setup/stubs.go Introduces stub templates for cache configuration and facade setup
cache/setup/setup.go Implements cache package installation/uninstallation logic with facade support

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@hwbrzzl hwbrzzl merged commit da8eed0 into master Sep 12, 2025
13 of 14 checks passed
@hwbrzzl hwbrzzl deleted the bowen/install-cache branch September 12, 2025 08:15
alfanzain pushed a commit to alfanzain/goravel-framework that referenced this pull request Sep 15, 2025
* feat: install Cache facade

* add tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant