Skip to content

Comments

feat: install Crypt facade#1192

Merged
hwbrzzl merged 5 commits intomasterfrom
bowen/install-crypt
Sep 13, 2025
Merged

feat: install Crypt facade#1192
hwbrzzl merged 5 commits intomasterfrom
bowen/install-crypt

Conversation

@hwbrzzl
Copy link
Contributor

@hwbrzzl hwbrzzl commented Sep 12, 2025

📑 Description

Relate goravel/goravel#612

image

✅ Checks

  • Added test cases for my code

@hwbrzzl hwbrzzl requested a review from a team as a code owner September 12, 2025 08:31
Copilot AI review requested due to automatic review settings September 12, 2025 08:31
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds facade support for the Crypt module by installing a Crypt facade generator and updating the setup process to handle facade installation/uninstallation. The changes also standardize facade stub generation across modules by removing direct imports of the facades package in favor of using the App() function directly.

  • Adds a new CryptFacade() stub generator for the Crypt module
  • Updates setup logic to conditionally install/remove the Crypt facade based on configuration
  • Standardizes facade stub generation by removing facades import dependencies

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
crypt/setup/stubs.go New file containing the CryptFacade stub generator
crypt/setup/setup.go Updates setup process to handle Crypt facade installation and removal
cache/setup/stubs.go Removes facades import and uses App() directly for consistency
auth/setup/stubs.go Removes facades import and uses App() directly for consistency

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codecov
Copy link

codecov bot commented Sep 12, 2025

Codecov Report

❌ Patch coverage is 21.05263% with 45 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.49%. Comparing base (da8eed0) to head (2b3c4fc).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
crypt/setup/stubs.go 0.00% 11 Missing ⚠️
crypt/setup/setup.go 0.00% 9 Missing ⚠️
auth/setup/stubs.go 0.00% 7 Missing ⚠️
cache/setup/stubs.go 0.00% 6 Missing ⚠️
foundation/console/package_uninstall_command.go 0.00% 4 Missing and 1 partial ⚠️
foundation/console/package_install_command.go 40.00% 2 Missing and 1 partial ⚠️
auth/setup/setup.go 0.00% 1 Missing ⚠️
cache/setup/setup.go 0.00% 1 Missing ⚠️
foundation/console/test_make_command.go 0.00% 0 Missing and 1 partial ⚠️
packages/setup.go 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1192      +/-   ##
==========================================
- Coverage   69.60%   69.49%   -0.11%     
==========================================
  Files         228      229       +1     
  Lines       14354    14391      +37     
==========================================
+ Hits         9991    10001      +10     
- Misses       4007     4032      +25     
- Partials      356      358       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

return res
}

func ModuleName() string {
Copy link
Contributor

@almas-x almas-x Sep 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about moving this function to packages/setup.go? There’s already a similar GetModulePath function there.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point

@hwbrzzl hwbrzzl requested review from almas-x and Copilot September 13, 2025 09:35
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 4 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@hwbrzzl hwbrzzl merged commit 20579c4 into master Sep 13, 2025
12 of 14 checks passed
@hwbrzzl hwbrzzl deleted the bowen/install-crypt branch September 13, 2025 15:00
alfanzain pushed a commit to alfanzain/goravel-framework that referenced this pull request Sep 15, 2025
* feat: install Crypt facade

* optimize

* fix tests

* address comments

* Update packages/setup.go

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants