Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds facade support for the Crypt module by installing a Crypt facade generator and updating the setup process to handle facade installation/uninstallation. The changes also standardize facade stub generation across modules by removing direct imports of the facades package in favor of using the App() function directly.
- Adds a new
CryptFacade()stub generator for the Crypt module - Updates setup logic to conditionally install/remove the Crypt facade based on configuration
- Standardizes facade stub generation by removing
facadesimport dependencies
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| crypt/setup/stubs.go | New file containing the CryptFacade stub generator |
| crypt/setup/setup.go | Updates setup process to handle Crypt facade installation and removal |
| cache/setup/stubs.go | Removes facades import and uses App() directly for consistency |
| auth/setup/stubs.go | Removes facades import and uses App() directly for consistency |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1192 +/- ##
==========================================
- Coverage 69.60% 69.49% -0.11%
==========================================
Files 228 229 +1
Lines 14354 14391 +37
==========================================
+ Hits 9991 10001 +10
- Misses 4007 4032 +25
- Partials 356 358 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
support/env/env.go
Outdated
| return res | ||
| } | ||
|
|
||
| func ModuleName() string { |
There was a problem hiding this comment.
How about moving this function to packages/setup.go? There’s already a similar GetModulePath function there.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 13 out of 13 changed files in this pull request and generated 4 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* feat: install Crypt facade * optimize * fix tests * address comments * Update packages/setup.go Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
📑 Description
Relate goravel/goravel#612
✅ Checks