feat: install Grpc, Hash, Http, Log, Mail facades#1195
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1195 +/- ##
==========================================
- Coverage 69.15% 68.55% -0.61%
==========================================
Files 231 228 -3
Lines 14461 14588 +127
==========================================
Hits 10001 10001
- Misses 4102 4229 +127
Partials 358 358 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hwbrzzl
changed the title
hwbrzzl
changed the title
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request implements facades installation for Grpc, Hash, Http, Log, and Mail packages as part of the framework's package setup system. The changes refactor how configuration and facade files are generated by moving from static file copying to dynamic stub generation.
- Refactors package setup to use dynamic stub generation instead of static config files
- Implements facade generation for Grpc, Hash, Http, Log, and Mail packages
- Adds conditional facade installation/uninstallation based on user selection
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| mail/setup/stubs.go | Adds stub generator for mail config and facade files |
| mail/setup/setup.go | Updates mail setup to use stubs and conditional facade installation |
| log/setup/stubs.go | Adds stub generator for log config and facade files |
| log/setup/setup.go | Updates log setup to use stubs and conditional facade installation |
| http/setup/stubs.go | Adds stub generators for HTTP, JWT, CORS configs and facades |
| http/setup/setup.go | Updates HTTP setup to use stubs and conditional facade installation |
| http/setup/config/*.go | Removes static config files replaced by dynamic stubs |
| hash/setup/stubs.go | Adds stub generator for hash config and facade files |
| hash/setup/setup.go | Updates hash setup to use stubs and conditional facade installation |
| grpc/setup/stubs.go | Adds stub generator for grpc config and facade files |
| grpc/setup/setup.go | Updates grpc setup to use stubs and conditional facade installation |
| filesystem/setup/config/filesystems.go | Removes static config file |
| contracts/binding/binding.go | Adds Http dependency to route binding |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
alfanzain
pushed a commit
to alfanzain/goravel-framework
that referenced
this pull request
Sep 15, 2025
* feat: install Grpc facade * install Hash facade * install Http facade * install Mail facade
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📑 Description
Relate goravel/goravel#612
✅ Checks