Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1196 +/- ##
==========================================
- Coverage 68.55% 67.91% -0.65%
==========================================
Files 228 233 +5
Lines 14588 14712 +124
==========================================
- Hits 10001 9991 -10
- Misses 4229 4363 +134
Partials 358 358 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hwbrzzl
commented
Sep 14, 2025
Comment on lines
-159
to
-170
| dependencyBindingsThatNeedUninstall := collect.Filter(bindingsThatNeedUninstall, func(bindingThatNeedUninstall string, _ int) bool { | ||
| return bindingThatNeedUninstall != binding | ||
| }) | ||
|
|
||
| if len(dependencyBindingsThatNeedUninstall) > 0 { | ||
| facadesThatNeedUninstall := make([]string, len(dependencyBindingsThatNeedUninstall)) | ||
| for i := range dependencyBindingsThatNeedUninstall { | ||
| facadesThatNeedUninstall[i] = convert.BindingToFacade(dependencyBindingsThatNeedUninstall[i]) | ||
| } | ||
|
|
||
| ctx.Info("The implicit dependency facades will be uninstalled as well: " + strings.Join(facadesThatNeedUninstall, ", ")) | ||
| } |
Contributor
Author
There was a problem hiding this comment.
The related facades will be installed simultaneously, but facades should be uninstalled one by one to avoid the related facades are being used.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements facade installation support for the Goravel framework by adding facade generation capabilities to various package setup scripts. The main purpose is to allow optional facade installation during package setup, providing a more convenient API interface for users.
- Adds facade stub generation methods to all package setup scripts
- Updates package installation/uninstallation logic to conditionally handle facade files
- Modifies the uninstall command to simplify facade dependency management
- Updates dependency mappings for Http and Testing bindings
Reviewed Changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| validation/setup/stubs.go | Adds ValidationFacade stub generation method |
| validation/setup/setup.go | Integrates facade installation/removal logic |
| translation/setup/stubs.go | Adds LangFacade stub generation method |
| translation/setup/setup.go | Integrates facade installation/removal logic |
| testing/setup/stubs.go | Adds TestingFacade stub generation method |
| testing/setup/setup.go | Integrates facade installation/removal logic |
| session/setup/stubs.go | Refactors to add both config and SessionFacade stub methods |
| session/setup/setup.go | Integrates facade installation/removal logic |
| schedule/setup/stubs.go | Adds ScheduleFacade stub generation method |
| schedule/setup/setup.go | Integrates facade installation/removal logic |
| route/setup/stubs.go | Adds RouteFacade stub generation method |
| route/setup/setup.go | Integrates facade installation/removal logic |
| queue/setup/stubs.go | Refactors to add both config and QueueFacade stub methods |
| queue/setup/setup.go | Integrates facade installation/removal logic |
| foundation/console/package_uninstall_command_test.go | Updates test expectations for simplified uninstall logic |
| foundation/console/package_uninstall_command.go | Simplifies facade uninstall logic to remove dependency chain handling |
| contracts/binding/binding.go | Updates Http and Testing binding dependencies |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
alfanzain
pushed a commit
to alfanzain/goravel-framework
that referenced
this pull request
Sep 15, 2025
* feat: install Queue facade * install Schedule facade * install Session facade * install Testing facade * install Lang facade * install Validation facade
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📑 Description
Relate goravel/goravel#612
✅ Checks