Conversation
|
I have two questions regarding this PR:
|
|
@almas-x Good question
|
If I remember correctly, when there is no facade or package input, it prompts to ask for the package or facade name, rather than selecting one. Based on the current “all-facades” logic, it either installs everything or requires entering the names one by one for installation. |
|
|
||
| dependencies := r.getDependenciesThatNeedInstall(binding) | ||
| if len(dependencies) > 0 { | ||
| if len(dependencies) > 0 && !ctx.OptionBool("all-facades") { |
There was a problem hiding this comment.
The Info is unnecessary when installing all facades.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1203 +/- ##
==========================================
+ Coverage 67.91% 67.96% +0.05%
==========================================
Files 233 232 -1
Lines 14712 14721 +9
==========================================
+ Hits 9991 10005 +14
+ Misses 4363 4357 -6
- Partials 358 359 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This pull request adds the ability to install all facades at once through a new --all-facades flag and improves the facade selection experience by replacing the text prompt with a multi-select menu. It also prevents duplicate facade installations within a single command execution.
- Added
--all-facadesflag to install all available facades without manual selection - Replaced text input prompt with interactive multi-select menu for facade selection
- Added duplicate installation prevention by tracking installed facades per command
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| foundation/console/package_install_command.go | Added --all-facades flag, multi-select UI, and duplicate prevention logic |
| foundation/console/package_install_command_test.go | Updated tests to cover new flag, multi-select functionality, and duplicate prevention |
| database/setup/stubs.go | Removed unused module parameter from Kernel method |
| database/setup/setup.go | Updated call to simplified Kernel method |
| contracts/binding/facades.go | Removed empty file |
| console/setup/setup.go | Removed entire file |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
📑 Description
Relate goravel/goravel#612
This pull request introduces several improvements and fixes to the package installation command, focusing on enhancing the facade installation workflow and its test coverage. The main changes include adding a new flag to install all facades, improving user interaction for facade selection, preventing duplicate installations within a single command execution, and updating related tests to cover these new scenarios.
Enhancements to facade installation workflow:
--all-facades(alias-a) flag to thePackageInstallCommand, allowing users to install all available facades at once without manual selection.--all-facadesis not set, users are now presented with a multi-select menu to choose one or more facades to install, with support for filtering and selecting all via keyboard shortcuts.installedFacadesInTheCurrentCommandfield. [1] [2] [3]✅ Checks