Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1205 +/- ##
==========================================
- Coverage 68.55% 68.13% -0.43%
==========================================
Files 228 235 +7
Lines 14588 15277 +689
==========================================
+ Hits 10001 10409 +408
- Misses 4229 4507 +278
- Partials 358 361 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hwbrzzl
reviewed
Sep 22, 2025
| mockSession := mocksession.NewSession(t) | ||
|
|
||
| mockCtx.EXPECT().Request().Return(mockRequest).Maybe() | ||
| mockRequest.EXPECT().HasSession().Return(tt.hasSession) |
Contributor
Author
There was a problem hiding this comment.
I have added various counts based on different conditions.
Contributor
Author
There was a problem hiding this comment.
OK, I thought we were talking about "Maybe" 😃
hwbrzzl
reviewed
Sep 25, 2025
Comment on lines
6
to
+9
| contractshttp "github.com/goravel/framework/contracts/http" | ||
| contractsession "github.com/goravel/framework/contracts/session" | ||
| foundationJson "github.com/goravel/framework/foundation/json" | ||
| configmocks "github.com/goravel/framework/mocks/config" | ||
| "github.com/goravel/framework/session" | ||
| sessionMiddleware "github.com/goravel/framework/session/middleware" | ||
| "github.com/goravel/framework/support/path" | ||
| mockhttp "github.com/goravel/framework/mocks/http" | ||
| mocksession "github.com/goravel/framework/mocks/session" | ||
| "github.com/stretchr/testify/assert" |
Contributor
There was a problem hiding this comment.
Suggested change
| contractshttp "github.com/goravel/framework/contracts/http" | |
| contractsession "github.com/goravel/framework/contracts/session" | |
| foundationJson "github.com/goravel/framework/foundation/json" | |
| configmocks "github.com/goravel/framework/mocks/config" | |
| "github.com/goravel/framework/session" | |
| sessionMiddleware "github.com/goravel/framework/session/middleware" | |
| "github.com/goravel/framework/support/path" | |
| mockhttp "github.com/goravel/framework/mocks/http" | |
| mocksession "github.com/goravel/framework/mocks/session" | |
| "github.com/stretchr/testify/assert" | |
| "github.com/stretchr/testify/assert" | |
| contractshttp "github.com/goravel/framework/contracts/http" | |
| mockhttp "github.com/goravel/framework/mocks/http" | |
| mocksession "github.com/goravel/framework/mocks/session" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📑 Description
Closes https://github.com/goravel/goravel/issues/
✅ Checks