Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1212 +/- ##
==========================================
- Coverage 67.75% 67.36% -0.39%
==========================================
Files 236 236
Lines 15486 15632 +146
==========================================
+ Hits 10493 10531 +38
- Misses 4628 4735 +107
- Partials 365 366 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes the installation process for the Route and HTTP modules by adding driver installation support and improving the setup workflow. The changes enable automatic installation of HTTP drivers when installing the Route facade and create necessary configuration files and middleware structure.
- Added driver installation support for facades that require drivers (Route with Gin/Fiber)
- Enhanced HTTP installation to create kernel.go file and improve code organization
- Improved configuration handling to support key updates rather than just additions
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| route/setup/stubs.go | Added Routes stub for generating routes/web.go file |
| route/setup/setup.go | Enhanced Route installation to create files and register middleware in AppServiceProvider |
| route/route.go | Added fallback handling when HTTP driver not configured and empty GlobalMiddleware method |
| packages/modify/actions_test.go | Fixed test assertion for config modification behavior |
| packages/modify/actions.go | Modified AddConfig to update existing keys instead of warning about duplicates |
| http/setup/stubs.go | Reorganized stubs and added Kernel stub for app/http/kernel.go |
| http/setup/setup.go | Improved variable organization and added kernel.go creation |
| grpc/setup/setup.go | Added clarifying comments for installation steps |
| foundation/console/package_install_command_test.go | Added comprehensive tests for driver installation functionality |
| foundation/console/package_install_command.go | Added installDriver method to handle driver selection and installation |
| contracts/binding/binding.go | Added Drivers field to binding.Info and defined Route drivers |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
📑 Description
Relate goravel/goravel#612
When installing Route:
app/http/kernel.go,routes/web.gofiles.facades.Route().GlobalMiddleware(http.Kernel{}.Middleware()...)androutes.Web()inapp/providers/app_service_provder.go::Boot.✅ Checks