Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1214 +/- ##
==========================================
- Coverage 67.11% 66.82% -0.30%
==========================================
Files 236 237 +1
Lines 15691 15784 +93
==========================================
+ Hits 10531 10547 +16
- Misses 4794 4871 +77
Partials 366 366 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.50.
| Benchmark suite | Current: 7cef125 | Previous: 1352230 | Ratio |
|---|---|---|---|
BenchmarkFile_ReadWrite |
312890 ns/op 6259 B/op 99 allocs/op |
193831 ns/op 6257 B/op 99 allocs/op |
1.61 |
BenchmarkFile_ReadWrite - ns/op |
312890 ns/op |
193831 ns/op |
1.61 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes the installation process for database-related packages by introducing automated dependency management and improving the setup workflow. The changes streamline the binding installation process and enhance the developer experience when setting up database functionality.
- Implements automated dependency calculation to install required bindings together
- Adds support for installing related bindings simultaneously (e.g., Schema with Orm)
- Refactors service providers to use a centralized dependency management system
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| support/binding/binding.go | New utility for calculating binding dependencies |
| support/collect/collect.go | Adds Diff function for slice comparison |
| foundation/console/package_install_command.go | Updates to use new dependency calculation logic |
| contracts/binding/binding.go | Adds InstallTogether field and reorganizes binding definitions |
| database/service_provider.go | Refactored to use centralized binding dependency management |
| auth/service_provider.go | Updated to use new dependency management pattern |
| http/service_provider.go | Refactored for consistency with new binding system |
| database/setup/setup.go | Enhanced installation workflow with proper facade registration |
| route/setup/setup.go | Adds welcome template creation during Route installation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
📑 Description
Relate goravel/goravel#612
facades.Schema().Register(database.Kernel{}.Migrations())andfacades.Seeder().Register(database.Kernel{}.Seeders())when installingSchemaandSeederfacades.welcome.tmplwhen installingRoute.✅ Checks