feat: package:install supports install internal package#1231
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1231 +/- ##
==========================================
+ Coverage 66.35% 66.42% +0.06%
==========================================
Files 245 245
Lines 16914 16946 +32
==========================================
+ Hits 11224 11256 +32
- Misses 5308 5310 +2
+ Partials 382 380 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hwbrzzl
changed the title
hwbrzzl
changed the title
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds support for installing internal drivers (e.g. database, memory, file, route) via a new --driver option, introduces a WhenDriver modifier, and extends binding metadata with driver definitions. Also refactors install logic to return errors and adjusts tests accordingly. Key changes:
- Added --driver parsing, options.Driver, WhenDriver modifier, and internal driver installation flow.
- Extended binding definitions with driver lists and updated tests for driver selection and installation.
- Changed several generated config stubs to hard-coded defaults (removing previous environment variable overrides).
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| session/setup/stubs.go | Hard-codes session default driver instead of reading from environment. |
| queue/setup/stubs.go | Hard-codes queue default connection value. |
| queue/setup/setup.go | Adds internal database driver config modification guarded by WhenDriver. |
| packages/setup_test.go | Updates mock expectations to include new driver option. |
| packages/setup.go | Adds driver field and passes Driver option to Apply. |
| packages/options/options_test.go | Adds test for new Driver option helper. |
| packages/options/options.go | Introduces Driver option function. |
| packages/modify/modify_test.go | Adds tests for WhenDriver behavior. |
| packages/modify/modify.go | Implements WhenDriver modifier struct and logic. |
| foundation/console/package_install_command_test.go | Adjusts error messages to lowercase and adds internal driver install test cases. |
| foundation/console/package_install_command.go | Returns errors from install helpers and adds internal driver branch; success message for internal driver. |
| filesystem/setup/stubs.go | Hard-codes filesystem default disk. |
| database/setup/setup.go | Reorders install steps; moves config/service provider creation earlier. |
| contracts/binding/binding.go | Adds driver metadata for multiple bindings (Cache, Queue, Session, Storage). |
| cache/setup/stubs.go | Hard-codes cache default store. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.50.
| Benchmark suite | Current: a8db6ba | Previous: 2d07c62 | Ratio |
|---|---|---|---|
Benchmark_EncryptString |
5151 ns/op 2152 B/op 14 allocs/op |
1610 ns/op 2152 B/op 14 allocs/op |
3.20 |
Benchmark_EncryptString - ns/op |
5151 ns/op |
1610 ns/op |
3.20 |
This comment was automatically generated by workflow using github-action-benchmark.
hwbrzzl
force-pushed
the
bowen/optimize-package-install
branch
from
856a4f8 to
a8db6ba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📑 Description
Closes https://github.com/goravel/goravel/issues/
Able to install internal package.
✅ Checks