Conversation
There was a problem hiding this comment.
Pull Request Overview
Adds a new Process binding and service provider to introduce a process facade into the framework.
- Introduces process.ServiceProvider with Relationship, Register, and Boot methods.
- Adds a new binding key (goravel.process) and binding metadata entry to contracts/binding.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| process/service_provider.go | New service provider that registers and wires the Process binding. |
| contracts/binding/binding.go | Adds Process binding constant and Bindings metadata entry. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1232 +/- ##
==========================================
- Coverage 66.19% 66.09% -0.11%
==========================================
Files 245 248 +3
Lines 16988 17069 +81
==========================================
+ Hits 11246 11282 +36
- Misses 5363 5410 +47
+ Partials 379 377 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.50.
| Benchmark suite | Current: 3d7bb58 | Previous: 9267451 | Ratio |
|---|---|---|---|
BenchmarkFile_ReadWrite |
432782 ns/op 6259 B/op 99 allocs/op |
288362 ns/op 6257 B/op 99 allocs/op |
1.50 |
BenchmarkFile_ReadWrite - ns/op |
432782 ns/op |
288362 ns/op |
1.50 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 22 out of 22 changed files in this pull request and generated 6 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
hwbrzzl
left a comment
There was a problem hiding this comment.
Amazing, a few nicpicks 👍
|
@hwbrzzl With this PR, I think the process facade (package) is ready to be used to invoke most command-line tools, both interactive and non-interactive. So I will be closing issue goravel/goravel#567 after merging this PR. |
hwbrzzl
left a comment
There was a problem hiding this comment.
Thanks, pretty good. Could you add the related document as well?
Yeah, Will add |
📑 Description
RelatedTo goravel/goravel#567
Previous PRs: #1171 , #1178 , #1215
Usage:
✅ Checks