Conversation
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.50.
| Benchmark suite | Current: c207416 | Previous: d55cef6 | Ratio |
|---|---|---|---|
BenchmarkFile_ReadWrite |
369371 ns/op 6259 B/op 99 allocs/op |
225781 ns/op 6258 B/op 99 allocs/op |
1.64 |
BenchmarkFile_ReadWrite - ns/op |
369371 ns/op |
225781 ns/op |
1.64 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1237 +/- ##
=======================================
Coverage 66.19% 66.19%
=======================================
Files 245 245
Lines 16988 16988
=======================================
Hits 11246 11246
Misses 5363 5363
Partials 379 379 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR adds a --module flag to the package installation command, passing the module name (github.com/goravel/framework) to the setup script's install command. This is required for proper package installation in github.com/goravel/redis.
Key Changes:
- Modified the package installation command to include
--moduleflag with the module name - Updated all test expectations to reflect the new command format with the
--moduleparameter
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| foundation/console/package_install_command.go | Added --module flag with module name to the setup install command |
| foundation/console/package_install_command_test.go | Updated all test mock expectations to include the new --module parameter in command strings |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
📑 Description
--moduleis required ingithub.com/goravel/redis.✅ Checks