Skip to content

Comments

feat: optimize package install#1237

Merged
hwbrzzl merged 1 commit intomasterfrom
bowen/optimize-package-install-1
Oct 19, 2025
Merged

feat: optimize package install#1237
hwbrzzl merged 1 commit intomasterfrom
bowen/optimize-package-install-1

Conversation

@hwbrzzl
Copy link
Contributor

@hwbrzzl hwbrzzl commented Oct 19, 2025

📑 Description

--module is required in github.com/goravel/redis.

✅ Checks

  • Added test cases for my code

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.50.

Benchmark suite Current: c207416 Previous: d55cef6 Ratio
BenchmarkFile_ReadWrite 369371 ns/op 6259 B/op 99 allocs/op 225781 ns/op 6258 B/op 99 allocs/op 1.64
BenchmarkFile_ReadWrite - ns/op 369371 ns/op 225781 ns/op 1.64

This comment was automatically generated by workflow using github-action-benchmark.

@codecov
Copy link

codecov bot commented Oct 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.19%. Comparing base (d55cef6) to head (c207416).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1237   +/-   ##
=======================================
  Coverage   66.19%   66.19%           
=======================================
  Files         245      245           
  Lines       16988    16988           
=======================================
  Hits        11246    11246           
  Misses       5363     5363           
  Partials      379      379           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hwbrzzl hwbrzzl marked this pull request as ready for review October 19, 2025 04:55
@hwbrzzl hwbrzzl requested a review from a team as a code owner October 19, 2025 04:55
Copilot AI review requested due to automatic review settings October 19, 2025 04:55
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a --module flag to the package installation command, passing the module name (github.com/goravel/framework) to the setup script's install command. This is required for proper package installation in github.com/goravel/redis.

Key Changes:

  • Modified the package installation command to include --module flag with the module name
  • Updated all test expectations to reflect the new command format with the --module parameter

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
foundation/console/package_install_command.go Added --module flag with module name to the setup install command
foundation/console/package_install_command_test.go Updated all test mock expectations to include the new --module parameter in command strings

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@hwbrzzl hwbrzzl merged commit 9267451 into master Oct 19, 2025
13 of 14 checks passed
@hwbrzzl hwbrzzl deleted the bowen/optimize-package-install-1 branch October 19, 2025 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant