Skip to content

feat: optimize database install#1238

Merged
hwbrzzl merged 2 commits intomasterfrom
bowen/optimize-database-install-1
Oct 19, 2025
Merged

feat: optimize database install#1238
hwbrzzl merged 2 commits intomasterfrom
bowen/optimize-database-install-1

Conversation

@hwbrzzl
Copy link
Contributor

@hwbrzzl hwbrzzl commented Oct 19, 2025

📑 Description

Uninstall the database configuration.

✅ Checks

  • Added test cases for my code

@hwbrzzl hwbrzzl requested a review from a team as a code owner October 19, 2025 08:56
Copilot AI review requested due to automatic review settings October 19, 2025 08:56
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds separate install and uninstall configuration action functions and introduces conditional removal of the database config file to avoid deleting user-customized configurations.

  • Renames configActionsFunc to installConfigActionsFunc and adds uninstallConfigActionsFunc.
  • Adds conditional logic to remove config/database.go only if it matches the original stub after uninstall actions.
  • Introduces per-key removal of database configuration entries during uninstall.

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Oct 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.22%. Comparing base (74dc501) to head (807c06d).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1238   +/-   ##
=======================================
  Coverage   66.22%   66.22%           
=======================================
  Files         245      245           
  Lines       16999    16999           
=======================================
  Hits        11257    11257           
  Misses       5363     5363           
  Partials      379      379           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hwbrzzl hwbrzzl merged commit bac2ee9 into master Oct 19, 2025
14 checks passed
@hwbrzzl hwbrzzl deleted the bowen/optimize-database-install-1 branch October 19, 2025 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants