feat: [#705] implement JsonGrammar to compile JSON queries#49
Merged
feat: [#705] implement JsonGrammar to compile JSON queries#49
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Implements JSON query compilation methods in the Postgres grammar, adds corresponding tests, and updates module dependencies.
- Add
CompileJsonContains,CompileJsonContainsKey, andCompileJsonLengthmethods togrammar.go - Provide comprehensive unit tests for the new JSON methods in
grammar_test.go - Update
go.mod(run throughgo mod tidy) to include new direct and indirect dependencies
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| grammar.go | Implement JSON‐related query compilation methods |
| grammar_test.go | Add unit tests for CompileJsonContains, ...Key, and ...Length |
| go.mod | Bump framework version and include various indirect dependencies |
Comments suppressed due to low confidence (1)
grammar.go:6
- The
slicesimport isn't used in this file and can be removed to avoid an unused import warning.
"slices"
hwbrzzl
approved these changes
Jun 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📑 Description
Closes goravel/goravel#705
Related goravel/framework#1074
✅ Checks