Skip to content

feat: [#705] implement JsonGrammar to compile JSON queries#49

Merged
almas-x merged 3 commits intomasterfrom
almas/#705
Jun 13, 2025
Merged

feat: [#705] implement JsonGrammar to compile JSON queries#49
almas-x merged 3 commits intomasterfrom
almas/#705

Conversation

@almas-x
Copy link
Contributor

@almas-x almas-x commented Jun 12, 2025

📑 Description

Closes goravel/goravel#705
Related goravel/framework#1074

✅ Checks

  • Added test cases for my code

@almas-x almas-x requested a review from hwbrzzl June 13, 2025 05:28
@hwbrzzl hwbrzzl requested a review from Copilot June 13, 2025 08:03
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Implements JSON query compilation methods in the Postgres grammar, adds corresponding tests, and updates module dependencies.

  • Add CompileJsonContains, CompileJsonContainsKey, and CompileJsonLength methods to grammar.go
  • Provide comprehensive unit tests for the new JSON methods in grammar_test.go
  • Update go.mod (run through go mod tidy) to include new direct and indirect dependencies

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
grammar.go Implement JSON‐related query compilation methods
grammar_test.go Add unit tests for CompileJsonContains, ...Key, and ...Length
go.mod Bump framework version and include various indirect dependencies
Comments suppressed due to low confidence (1)

grammar.go:6

  • The slices import isn't used in this file and can be removed to avoid an unused import warning.
    "slices"

hwbrzzl
hwbrzzl previously approved these changes Jun 13, 2025
Copy link
Contributor

@hwbrzzl hwbrzzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing 👍

@almas-x almas-x merged commit 896f37e into master Jun 13, 2025
5 checks passed
@almas-x almas-x deleted the almas/#705 branch June 13, 2025 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

facades.Orm().Query() Support JSON Where Clauses

3 participants