Merged
Conversation
Signed-off-by: eternal-flame-AD <yume@yumechi.jp>
Signed-off-by: eternal-flame-AD <yume@yumechi.jp>
Signed-off-by: eternal-flame-AD <yume@yumechi.jp>
eternal-flame-AD
force-pushed
the
docker-multiarch
branch
from
97a8020 to
ce9abd8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #703 +/- ##
==========================================
- Coverage 80.46% 79.42% -1.05%
==========================================
Files 56 56
Lines 2191 2639 +448
==========================================
+ Hits 1763 2096 +333
- Misses 337 452 +115
Partials 91 91 ☔ View full report in Codecov by Sentry. |
Signed-off-by: eternal-flame-AD <yume@yumechi.jp>
Member
Author
|
Here's the Docker scout cloud analysis, you should be able to reproduce it with Sorry about the force pushes, messed up a rebase :( Details
|
Signed-off-by: eternal-flame-AD <yume@yumechi.jp>
eternal-flame-AD
force-pushed
the
docker-multiarch
branch
2 times, most recently
from
9caea83 to
377ef3c
Compare
jmattheis
requested changes
Oct 18, 2024
Member
jmattheis
left a comment
jmattheis
left a comment
There was a problem hiding this comment.
Nicely done, some remarks in subcomments.
jmattheis
reviewed
Oct 18, 2024
Signed-off-by: eternal-flame-AD <yume@yumechi.jp>
Signed-off-by: eternal-flame-AD <yume@yumechi.jp>
Signed-off-by: eternal-flame-AD <yume@yumechi.jp>
Signed-off-by: eternal-flame-AD <yume@yumechi.jp>
jmattheis
reviewed
Oct 19, 2024
Signed-off-by: eternal-flame-AD <yume@yumechi.jp>
Signed-off-by: eternal-flame-AD <yume@yumechi.jp>
Signed-off-by: eternal-flame-AD <yume@yumechi.jp>
Signed-off-by: eternal-flame-AD <yume@yumechi.jp>
eternal-flame-AD
requested review from
jmattheis
and removed request for
jmattheis
jmattheis
approved these changes
Oct 22, 2024
Member
jmattheis
left a comment
jmattheis
left a comment
There was a problem hiding this comment.
Probably good to squash the many commits into one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #257 .
fixes #350
Simply
make build-docker-multiarchand thendocker runshould work. I implemented building JS from docker as well but opt-in, just for people who want's to build a usable local container without having to do anything outside of docker.Current blockers: (nevermind I had a nap and figured out how to do it)
The last step of installing runtime dependency need qemu, it's not easy to get around that unfortunately