bug: fixed router navigating to homepage on page loads#723
bug: fixed router navigating to homepage on page loads#723jmattheis merged 2 commits intogotify:masterfrom
Conversation
eternal-flame-AD
assigned
eternal-flame-AD and
jmattheis and unassigned
eternal-flame-AD
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #723 +/- ##
=======================================
Coverage 79.42% 79.42%
=======================================
Files 56 56
Lines 2639 2639
=======================================
Hits 2096 2096
Misses 452 452
Partials 91 91 ☔ View full report in Codecov by Sentry. |
| @@ -99,7 +99,9 @@ export class CurrentUser { | |||
| }; | |||
There was a problem hiding this comment.
FYI: your commits aren't linked to your GitHub account. See the email in https://github.com/gotify/server/pull/723/commits/eaa19ddcb110296b7fd49e8589f2c5a3b22b2b55.patch
david-kalmakoff
force-pushed
the
issue-721
branch
from
eaa19dd to
2e1f27d
Compare
ui/src/CurrentUser.ts
Outdated
| }; | ||
|
|
||
| public tryAuthenticate = async (): Promise<AxiosResponse<IUser>> => { | ||
| this.authenticating = true; |
There was a problem hiding this comment.
I've removed this line, as I think we don't want to show the loading spinner, when we try to reconnect after there was a successful connection. I've set this.authenticating to true on variable initialization, so it should behave the same.
| @@ -99,7 +99,9 @@ export class CurrentUser { | |||
| }; | |||
|
|
|||
| public tryAuthenticate = async (): Promise<AxiosResponse<IUser>> => { | |||
There was a problem hiding this comment.
The plugin detail page threw an exception because the plugin data wasn't loaded there.
3 participants
Fixes #721
authenticatingstatus whentryAuthenticatingis called