Conversation
The setup-go action, sets GOTOOLCHAIN=local and breaks the release build.
Don't redirect to /#/login when the tryAuthenticate hasn't completed. This caused the url path to be changed to /#/login regardaless if the user was already logged in.
jmattheis
commented
Sep 13, 2025
| else | ||
| GO_VERSION=$(shell go mod edit -json | jq -r .Toolchain | sed -e 's/go//') | ||
| endif | ||
| GO_VERSION=$(shell go mod edit -json | jq -r .Toolchain | sed -e 's/go//') |
Member
Author
There was a problem hiding this comment.
FYI @eternal-flame-AD I've removed the GOTOOLCHAIN check here, because in a new version of actions/setup-go the variable is set to local which breaks this logic here. I think if someone from the outside wants to change the use go version, they can directly set GO_VERSION.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #838 +/- ##
=======================================
Coverage 79.54% 79.54%
=======================================
Files 56 56
Lines 2645 2645
=======================================
Hits 2104 2104
Misses 450 450
Partials 91 91 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.