Merged
Conversation
Contributor
Author
Delete.image.webm |
jmattheis
reviewed
Oct 8, 2025
ui/src/application/Applications.tsx
Outdated
| image, | ||
| fEdit, | ||
| }: IRowProps) => { | ||
| const [isHovered, setIsHovered] = useState(false); |
Member
There was a problem hiding this comment.
I've changed this to handle the hover effect purely with css and the image always has the onclick handler to delete the image. This make this simpler IMO.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #855 +/- ##
=======================================
Coverage 78.76% 78.76%
=======================================
Files 56 56
Lines 2670 2670
=======================================
Hits 2103 2103
Misses 476 476
Partials 91 91 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jmattheis
approved these changes
Oct 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I add a delete button (appearing when the mouse hovers over image)
After confirmation, the delete is done (the API 'DELETE /:id/image' is used) and a snack notification is created