Use common Markdown for descriptions#290
Merged
wincent merged 2 commits intographql:masterfrom Apr 6, 2017
RomanHotsiy:patch-1
Merged
Use common Markdown for descriptions#290wincent merged 2 commits intographql:masterfrom RomanHotsiy:patch-1
wincent merged 2 commits intographql:masterfrom
RomanHotsiy:patch-1
Conversation
wincent
reviewed
Mar 28, 2017
Contributor
wincent
left a comment
wincent
left a comment
There was a problem hiding this comment.
Thanks @RomanGotsiy. Makes sense to me, but I'll leave this open for a while to give others a chance to chime in.
spec/Section 4 -- Introspection.md
Outdated
| All types in the introspection system provide a `description` field of type | ||
| `String` to allow type designers to publish documentation in addition to | ||
| capabilities. A GraphQL server may return the `description` field using Markdown | ||
| capabilities. A GraphQL server may return the `description` field using [Common Markdown](http://spec.commonmark.org/) |
Contributor
There was a problem hiding this comment.
Seems like this long line would best be wrapped.
Contributor
|
And for reference, I looked up this GitHub blog post on the subject of the Markdown spec. |
Contributor
|
Ok, going to apply a couple of tweaks and merge this (namely, that the spec is called "CommonMark" and doesn't refer to "Common Markdown"). Thanks! |
- Link to http://commonmark.org/ rather than http://spec.commonmark.org/ as it provides a more user-friendly landing point. - "Common Markdown" → "CommonMark" - Backticks around "description".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are a lot of different Markdown dialects. Let's stick to Common Markdown as it was recently done by GitHub and others.
I believe most of markdown renderers will support soon or already support Common Markdown.