Conversation
mununki
approved these changes
Mar 29, 2024
src/Garter_Array.res
Outdated
| let distinct = (ar, ~id) => | ||
| ar | ||
| ->reduceU((Belt.Set.make(~id), list{}), ((seen, res), v) => | ||
| let distinctBy = (type a, arr: array<a>, f) => { |
| */ | ||
| let frequencies: (array<'a>, ~id: Belt.Map.id<'a, 'b>) => Belt.Map.t<'a, int, 'b> | ||
|
|
||
| /** |
Contributor
Author
There was a problem hiding this comment.
Garter_Array.res에서는 distinct가 내부적으로 distinctBy를 사용하고 있어 distinctBy가 먼저 선언되어 있습니다. resi에서도 순서를 통일하는 것을 어떤가요?
NonEmpty의 distinct, distinctBy와 순서가 달라서라면 NonEmpty의 순서를 바꿔도 좋을 것 같습니다!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
배열 요소에 대해서 중복을 제거하기 위해서는 아래와 같이 사용할 수 있습니다.
특정 key에 대해서 중복을 제거하기 위해서 아래와 같이 사용할 수 있습니다.