Stop leaking this from BinderServerTransport's ctor#12453
Merged
jdcormie merged 1 commit intogrpc:masterfrom Oct 31, 2025
Merged
Stop leaking this from BinderServerTransport's ctor#12453jdcormie merged 1 commit intogrpc:masterfrom
this from BinderServerTransport's ctor#12453jdcormie merged 1 commit intogrpc:masterfrom
Conversation
ejona86
reviewed
Oct 30, 2025
Member
There was a problem hiding this comment.
Why not change BinderServer?
BinderServerTransport transport =
new BinderServerTransport(...);
transport.setOutgoingBinder(callbackBinder, executor);
transprot.start(listener.transportCreated(transport));(Alternatively, create a factory method to call instead of the constructor.)
jdcormie
force-pushed
the
unify-doa-handling
branch
from
f084896 to
4afb66c
Compare
Member
Author
done |
jdcormie
force-pushed
the
unify-doa-handling
branch
2 times, most recently
from
6e7d5d9 to
5a29d7a
Compare
Also add a test for the DOA case and document why ignoring errors from setOutgoingBinder() is ok.
jdcormie
force-pushed
the
unify-doa-handling
branch
from
5a29d7a to
89dcc2a
Compare
jdcormie
changed the title
this from BinderServerTransport's ctor
jdcormie
force-pushed
the
unify-doa-handling
branch
from
89dcc2a to
b4cfb90
Compare
jdcormie
changed the title
jdcormie
changed the title
this from BinderServerTransport's ctor
ejona86
approved these changes
Oct 31, 2025
AgraVator
pushed a commit
to AgraVator/grpc-java
that referenced
this pull request
Nov 3, 2025
Accomplish this with a new factory method. Document why ignoring errors from setOutgoingBinder() is ok. Add a test for a dead-on-arrival client binder.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accomplish this by splitting out the linkToDeath() part of setOutgoingBinder().
Also add a test for the DOA case and document why ignoring errors from linkToDeath() is ok.