export as target#24
Merged
gulrak merged 1 commit intogulrak:masterfrom Sep 29, 2019
JonasVautherin:export-target
Merged
Conversation
BotellaA
reviewed
Aug 15, 2019
Owner
|
Sorry that I din't react on this one yet. I need to look further into this, as I don't currently use the feature myself and it already came from a PR (#14) from @fenglc, so I want to at least check the impact on some configurations. |
BotellaA
reviewed
Aug 16, 2019
|
Any update on this PR? Thank you all |
Owner
|
I'll look into this this weekend. Sorry it takes so long. |
Owner
|
Finally, thanks for the PR and sorry for the long delay. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is trying to export
ghc-filesystemas a target, so you can include it withghcFilesystem::ghc_filesystemin cmake projects.I am not completely sure if I broke something that was existing before, but it seems to be working for me. Let me know what you think.