Type class for different auth methods#365
Merged
phadej merged 1 commit intohaskell-github:masterfrom May 23, 2019
Merged
Conversation
robbiemcmichael
force-pushed
the
auth-method
branch
from
90a9c9a to
8b0ddfd
Compare
phadej
approved these changes
May 23, 2019
Contributor
phadej
left a comment
phadej
left a comment
There was a problem hiding this comment.
This looks great. Exactly in a spirit "provide means to extend existing functionality"
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a type class which allows users of the library to define alternative authentication methods. This is required to support JWT auth which is required by GitHub Apps, however we may not want to add GitHub app support to this library directly since they are currently part of GitHub's API previews which are not stable.