Add unwatch request#473
Conversation
414owen
force-pushed
the
add-unsubscribe-request
branch
from
b120986 to
5281a50
Compare
|
@Mergifyio rebase |
✅ Branch has been successfully rebased |
andreasabel
force-pushed
the
add-unsubscribe-request
branch
from
5281a50 to
7498a53
Compare
|
@414owen : Can this PR be complemented by a test case or a demonstration in |
andreasabel
left a comment
andreasabel
left a comment
There was a problem hiding this comment.
Please supply a testcase or demo.
|
@andreasabel I've added a sample to demonstrate usage of |
andreasabel
left a comment
andreasabel
left a comment
There was a problem hiding this comment.
Thanks for the update!; see my comment.
samples/Repos/Watching/Unwatch.hs
Outdated
| @@ -0,0 +1,17 @@ | |||
| {-# LANGUAGE OverloadedStrings #-} | |||
|
|
|||
| module Unwatch where | |||
There was a problem hiding this comment.
Could you please add this to the executables in samples/github-samples.cabal so that it gets built by the CI?
(You will likely have to delete the module header or change it to Main to get ghc to build the executable.)
There was a problem hiding this comment.
As I suspected, a main module can only have name Main (or no name):
Building executable 'github-unwatch-repo' for github-samples-0..
[1 of 1] Compiling Unwatch ( Repos/Watching/Unwatch.hs, /__w/github/github/dist-newstyle/build/x86_64-linux/ghc-8.0.2/github-samples-0/x/github-unwatch-repo/noopt/build/github-unwatch-repo/github-unwatch-repo-tmp/Unwatch.o )
<no location info>: error:
output was redirected with -o, but no output will be generated
because there is no Main module.
andreasabel
left a comment
andreasabel
left a comment
There was a problem hiding this comment.
Please fix CI problems (Main module).
414owen
force-pushed
the
add-unsubscribe-request
branch
from
4ae5f0a to
c527dbe
Compare
|
Thanks a lot, @414owen ! |
2 participants
I ended up subscribed to a bunch of repositories, through some automated process.
This helped clear it up.
@phadej