Skip to content

Support base < 4.6 / GHC 7.4. #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ekmett merged 1 commit into from
Aug 25, 2014
Merged

Support base < 4.6 / GHC 7.4. #12

ekmett merged 1 commit into from
Aug 25, 2014

Conversation

@23Skidoo
Copy link
Member

@23Skidoo 23Skidoo commented Aug 23, 2014

Fixes #10.

@23Skidoo
Copy link
Member Author

23Skidoo commented Aug 23, 2014

Someone also needs to edit the Hackage package information for the 1.0.1.3 release and set the lower bound for the base dependency to 4.6.

@cartazio
Copy link
Contributor

cartazio commented Aug 25, 2014

@ekmett should be on scene soon :)

ekmett added a commit that referenced this pull request Aug 25, 2014
@ekmett
Merge pull request #12 from 23Skidoo/unbreak-ghc-7.4
ad4de49 
Support base < 4.6 / GHC 7.4.
@ekmett ekmett merged commit ad4de49 into haskell:master Aug 25, 2014
@23Skidoo 23Skidoo deleted the unbreak-ghc-7.4 branch August 25, 2014 19:42
@23Skidoo 23Skidoo mentioned this pull request Aug 25, 2014
Closed
@23Skidoo
Copy link
Member Author

23Skidoo commented Aug 25, 2014

Thanks!

@ekmett
Copy link
Member

ekmett commented Aug 25, 2014

It may be after ICFP before I get a chance to push that up to hackage, but it is now officially on my TODO list.

@23Skidoo
Copy link
Member Author

23Skidoo commented Aug 25, 2014

No problem, it's not urgent.

@sol
Copy link
Member

sol commented Aug 26, 2014

Can we please get this on Hackage or alternatively sort out #14. Currently it's not possible to generate pseudorandomness in a controlled/reproducible manner that works with GHC < 7.6.* without putting an upper bound on random.

Putting an upper bound on random, say random < 1.0.1.3 would work, but is not an option for me.

@sol
Copy link
Member

sol commented Aug 26, 2014

@ekmett If there is anything that I can do to help, please let me know.

@cartazio
Copy link
Contributor

cartazio commented Aug 26, 2014

@sol If ekmett gives me the ok, i can help cut a release.

@sol sol mentioned this pull request Aug 26, 2014
Closed
jsonn pushed a commit to jsonn/pkgsrc that referenced this pull request Oct 22, 2014
Update to 1.1
0dec1c3 
from CHANGELOG & https://github.com/haskell/random
# 1.1
  * support for base < 4.6 (which doesnt provide strict atomicModifyIORef')
    and integrating Travis CI support.
    haskell/random#12
  * fix C type in test suite haskell/random#9
  - Fix compilation with GHC HEAD.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Does not build with GHC-7.4.2 / base < 4.6

4 participants

@23Skidoo @cartazio @ekmett @sol