Skip to content

Conversation

@bgamari
Copy link
Contributor

@bgamari bgamari commented Mar 23, 2014

On some architectures types like CChar are signed whereas the use previously
assumed they were unsigned. Fix this by relying on Bounded instances where
possible.

@bgamari
Copy link
Contributor Author

bgamari commented Jun 1, 2014

Ping?

On some architectures types like CChar are signed whereas the use previously
assumed they were unsigned. Fix this by relying on Bounded instances where
possible.
This reverts commit 2117e38.

We no longer assume that C types are unsigned.
@bgamari
Copy link
Contributor Author

bgamari commented Aug 19, 2014

How's this look?

rrnewton added a commit that referenced this pull request Aug 22, 2014
rangeTest: Fix signed-ness of types
@rrnewton rrnewton merged commit dedcb54 into haskell:master Aug 22, 2014
@rrnewton
Copy link
Member

Looks good for me, very sorry for delay.

@thomie
Copy link
Contributor

thomie commented Aug 22, 2014

@rrnewton Thanks for merging all the patches, and the release.

@bgamari There is still one small typo:

(undefined:: CWchar)

should be changed to:

(undefined:: CSigAtomic)

On the line that starts with:

checkBounds "CSigAtomic R"

@bgamari
Copy link
Contributor Author

bgamari commented Aug 22, 2014

@thomie very good catch, sir.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants