add: commits from another branch that was done#197
Merged
imOscarCrespo merged 47 commits intomasterfrom Aug 26, 2019
Merged
Conversation
Bumps [node-nlp](https://github.com/axa-group/nlp.js) from 3.4.0 to 3.6.0. - [Release notes](https://github.com/axa-group/nlp.js/releases) - [Commits](https://github.com/axa-group/nlp.js/commits) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.513.0 to 2.517.0. - [Release notes](https://github.com/aws/aws-sdk-js/releases) - [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md) - [Commits](aws/aws-sdk-js@v2.513.0...v2.517.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [eslint-plugin-jest](https://github.com/jest-community/eslint-plugin-jest) from 22.15.0 to 22.15.2. - [Release notes](https://github.com/jest-community/eslint-plugin-jest/releases) - [Changelog](https://github.com/jest-community/eslint-plugin-jest/blob/master/CHANGELOG.md) - [Commits](jest-community/eslint-plugin-jest@v22.15.0...v22.15.2) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [@types/jest](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/jest) from 24.0.17 to 24.0.18. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/jest) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 12.7.1 to 12.7.2. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [core-js](https://github.com/zloirock/core-js) from 3.2.0 to 3.2.1. - [Release notes](https://github.com/zloirock/core-js/releases) - [Changelog](https://github.com/zloirock/core-js/blob/master/CHANGELOG.md) - [Commits](zloirock/core-js@v3.2.0...v3.2.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [react-hot-loader](https://github.com/gaearon/react-hot-loader) from 4.12.10 to 4.12.11. - [Release notes](https://github.com/gaearon/react-hot-loader/releases) - [Changelog](https://github.com/gaearon/react-hot-loader/blob/master/CHANGELOG.md) - [Commits](gaearon/react-hot-loader@v4.12.10...v4.12.11) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
* fix(contentful): replies format was different than expected by botonic react * chore(contentful): improvements in eslint config
dpinol
reviewed
Aug 26, 2019
| @@ -37,6 +37,7 @@ export const Button = props => { | |||
| else if (props.path) sendPayload(`__PATH_PAYLOAD__${props.path}`) | |||
| else if (props.payload) sendPayload(props.payload) | |||
Contributor
There was a problem hiding this comment.
@ericmarcos if we allowed having both payload and url, would we be able to open an url and send a track when user presses a button?
dpinol
suggested changes
Aug 26, 2019
|
|
||
| const sendInput = async input => { | ||
| let isRegex = false | ||
| let inputMessage = null |
Contributor
There was a problem hiding this comment.
this method is too long. Maybe we can split it using a private method for text inputs?
Contributor
Author
There was a problem hiding this comment.
updated with the last PR
| let handoff = action.startsWith('create_case') | ||
| if (handoff && isDev()) addMessageComponent(<Handoff />) | ||
| updateHandoff(handoff) | ||
| if (!isRegex) { |
Contributor
There was a problem hiding this comment.
it looks like isRegex is not defined here
…to persistentMenuBotonic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've created this branch becouse I had a problem with the "persistenMenu" branch. It's a copy of that. In this PR I've customized the persistent menu in case that it exists.