GDriveFileSystem: Raise FIleNotFoundError on ls.#283
Conversation
| _, base = fs.split_path(remote_dir + "dir/") | ||
| fs._path_to_item_ids(base, create=True) | ||
| assert fs.ls(remote_dir + "dir/") == [] |
There was a problem hiding this comment.
Turns out, fs.mkdir() is not implemented in GDriveFileSystem. I was not sure if it was needed as it has been working fine for so long. So I only fixed in test to create a directory.
|
Investigating some failures in treeverse/dvc-gdrive#28. Will merge this after they turn green. |
|
Looks like |
What is the failure or case where is not working? |
See treeverse/dvc-gdrive#28. The following returns an empty list even though the file exists, failing >>> fs.find("root/<>/files/md5")
[]I am still trying to understand internals of GDriveFileSystem on how to fix it. This piece of code is problematic: Lines 476 to 482 in a5dc1d9 |
Co-authored-by: Ruslan Kuprieiev <kupruser@gmail.com>
mkdir in GDriveFileSystem is a noop.
Per treeverse/dvc-gdrive#29