Conversation
Looks like this was an anti pattern that stuck around from some early days. Fixes treeverse/dvc-gdrive#31
shcheklein
approved these changes
Jul 4, 2023
Member
shcheklein
left a comment
shcheklein
left a comment
There was a problem hiding this comment.
Thanks. Do we need a test for this?
Contributor
Author
|
@shcheklein Did consider it, but I don't think it is worth it. It is just an anti-pattern that needed to be fixed (and linters, which are unfortunately not enabled apparently, should catch this). Will wait a bit for the confirmation from the user. |
maltempi
approved these changes
Jul 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like this was an anti pattern that stuck around from some early days.
Fixes treeverse/dvc-gdrive#31