fix(fs): remove DVC-specific broken cache optimization#321
Merged
shcheklein merged 1 commit intomainfrom Dec 18, 2023
Merged
Conversation
efiop
approved these changes
Dec 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To mitigate treeverse/dvc-gdrive#38
It removes the pre-caching logic of
root/00,root/01, ....root/ffDVC cache specific directories. It existed to optimize number of API calls, specifically when we useexistscalls on the DVC transfer side and we have to do 2x calls in some simple scenarios. It's slower and expensive.With this PR cache is becoming more general (e.g. we cache all directories we create). It makes sense for
fsspec. To make it clear - the wholefsspecimplementation in general case is still very broken and it'll be addressed step by step eventually.The optimization can be turned back on with ad additional "pre_cache_path" argument. But let's do it after we fix the basic GDrive scenario with this one.