-
Notifications
You must be signed in to change notification settings - Fork 9
add in just-lsp support #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d2ae826 to
71fb200
Compare
71fb200 to
912d41e
Compare
Along with this: * update tree-sitter grammar * update README
912d41e to
cb9ec69
Compare
| [grammars.just] | ||
| repository = "https://github.com/IndianBoy42/tree-sitter-just" | ||
| commit = "3f90d24eb8c8d9e8c74fee7120d79c3ec7229f26" | ||
| commit = "bb0c898a80644de438e6efe5d88d30bf092935cd" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you know what the meaning of this change is? Have you tested it? I have a very vague memory when I made this extension of choosing a specific commit because some other one didn't work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't review the changes, but it definitely works when I run it as a dev extension. This is just the upstream grammar we pull in that tree-sitter uses. Just uhh, pulled latest of that. It compiles and works, so seems fine?
Is there something hyper specific you were interested in?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, just wanted to be sure it worked.
|
@jackTabsCode do you wanna get a 0.2.0 tagged and bumped in the Zed extension repo? Happy to help, but that's not something I can toss up a PR for. :) I've been running latest |
|
I can do that this weekend. |
|
@mattrobenolt Have you seen https://github.com/sectore/zed-just-ls ? An extension for supporting |
Since [zed-just](https://github.com/jackTabsCode/zed-just) extension has added its own [`just-lsp` support](jackTabsCode/zed-just#25), `zed-just-ls` extension is not needed anymore. A note has been added to https://github.com/sectore/zed-just-ls, too.
Since [zed-just](https://github.com/jackTabsCode/zed-just) extension has added its own [`just-lsp` support](jackTabsCode/zed-just#25), `zed-just-ls` extension is not needed anymore. A note has been added to https://github.com/sectore/zed-just-ls, too.
Along with this: