Annotations from container source not applied to kubernetes deployment

[MatthiasDrews]

Describe the bug
We have a container source with dedicated annotations on the template:

apiVersion: sources.knative.dev/v1
kind: ContainerSource
...
spec:
  template:
    metadata:
      annotations:
        timestamp: 2025-03-27T13:54:57+0000
...

Expected behavior
I expect the annotation to be present also in the generated kubernetes Deployment, as described in the documentation: A template in the shape of Deployment.spec.template to be used for this ContainerSource.. However it is missing:

kind: Deployment
apiVersion: apps/v1
spec:
  template:
      metadata:
        creationTimestamp: null
        labels:
          sources.knative.dev/containerSource: ...
          sources.knative.dev/source: container-source-controller

To Reproduce
Steps to reproduce the behavior.

Knative release version
1.17.3

Additional context

[eloo-abi]

maybe its related to missing annotations here?
https://github.com/knative/eventing/blob/main/pkg/reconciler/containersource/resources/deployment.go#L41-L48

[matzew]

I just tested on main and on our release-1.17 branch, with something like:

apiVersion: sources.knative.dev/v1
kind: ContainerSource
metadata:
  name: kamelet-source
  namespace: knative-samples
spec:
  template:
    metadata:
      annotations:
        timestamp: 2025-03-27T13:54:57+0000
        foo: "Bar"  
    spec:
      containers:
....

and the matching Deployment looks like:

apiVersion: apps/v1
kind: Deployment
metadata:
  annotations:
    deployment.kubernetes.io/revision: "6"
  creationTimestamp: "2025-04-08T12:17:55Z"
  generation: 8
  labels:
    sources.knative.dev/containerSource: kamelet-source
    sources.knative.dev/source: container-source-controller
  name: kamelet-source-deployment
  namespace: knative-samples
  ownerReferences:
  - apiVersion: sources.knative.dev/v1
    blockOwnerDeletion: true
    controller: true
    kind: ContainerSource
    name: kamelet-source
    uid: a33750a4-be47-4b0a-bb3b-cdf2fb3e8331
  resourceVersion: "8160"
  uid: 4b4cf8d6-fd3d-4539-91ad-455b051c1d6f
spec:
  progressDeadlineSeconds: 600
  replicas: 1
  revisionHistoryLimit: 10
  selector:
    matchLabels:
      sources.knative.dev/containerSource: kamelet-source
      sources.knative.dev/source: container-source-controller
  strategy:
    rollingUpdate:
      maxSurge: 25%
      maxUnavailable: 25%
    type: RollingUpdate
  template:
    metadata:
      annotations:
        foo: Bar
        timestamp: 2025-03-27T13:54:57+0000
      creationTimestamp: null
      labels:
        sources.knative.dev/containerSource: kamelet-source
        sources.knative.dev/source: container-source-controller
    spec:
      containers:
      - env:
...
...

It seems to be present. Or am I missing something?

[matzew]

FWIW I also see the annotation when I set it via code, e.g. via the reconcile for the IntegrationSource, which uses internally the ContainerSource

[eloo-abi]

@matzew i have just rechecked it and yes you have partly a point here.

it looks like it is working for newly created deployments.
so we have some with annotations and some without.

but it looks like updating the annotation is not working.
so not all changes from the template in the containersource are not replicated to the deployment

maybe something in the reconciler here is missing

[matzew]

I saw this and will take a look. Thanks for reporting

[matzew]

@eloo-abi so, the reconciler does only check for changes on the .Spec of the template, not the metadata, like the annotations... Not exactly sure why that was done that way initially ... 🤷‍♂

But I have proposed a simple fix: #8558

[eloo-abi]

@matzew ah okay. yes that makes sense why the annotations or labels are not updated properly..

sounds good :) looking forward to test this

[matzew]

@eloo-abi we have backported this to 1.17 branch, and it might be merged in time for a new .z release

[matzew]

Release 1.17.5 was just cut a couple of minutes ago:

https://github.com/knative/eventing/tree/knative-v1.17.5