Skip to content

Added tristate flags and changed experimental config map name#5459

Merged
knative-prow-robot merged 6 commits intoknative:mainfrom
slinkydeveloper:change_name_cm
Jun 1, 2021
Merged

Added tristate flags and changed experimental config map name#5459
knative-prow-robot merged 6 commits intoknative:mainfrom
slinkydeveloper:change_name_cm

Conversation

@slinkydeveloper
Copy link
Contributor

@slinkydeveloper slinkydeveloper commented Jun 1, 2021

Signed-off-by: Francesco Guardiani francescoguard@gmail.com

Address suggestions on the mail thread https://groups.google.com/u/0/g/knative-dev/c/M_10Rh_30ho

Proposed Changes

  • 🧹 Renamed config-experimental-features CM to config-features
  • 🧹 Added the tristate Flag value
  • 🧹 Renamed experimental package to feature package, and renamed test packages to feature_test (to avoid circular refs with other api packages)
  • 🎁 Added the flag_names file, where we should place all the different flags

Pre-review Checklist

  • At least 80% unit test coverage
  • E2E tests for any new behavior: N/A
  • Docs PR for any user-facing impact: Added the experimental features page docs#3676
  • Spec PR for any new API feature: N/A
  • Conformance test for any change to the spec: N/A

Renamed experimental features config map

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 1, 2021
@knative-prow-robot knative-prow-robot added area/test-and-release Test infrastructure, tests or release size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 1, 2021
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@codecov
Copy link

codecov bot commented Jun 1, 2021

Codecov Report

Merging #5459 (3787ec8) into main (d1106c8) will decrease coverage by 0.00%.
The diff coverage is 90.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5459      +/-   ##
==========================================
- Coverage   82.76%   82.75%   -0.01%     
==========================================
  Files         197      197              
  Lines        6086     6090       +4     
==========================================
+ Hits         5037     5040       +3     
- Misses        724      725       +1     
  Partials      325      325              
Impacted Files Coverage Δ
pkg/apis/feature/api_validation.go 93.10% <ø> (ø)
pkg/apis/feature/store.go 87.50% <50.00%> (ø)
pkg/apis/feature/features.go 87.50% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1106c8...3787ec8. Read the comment docs.

slinkydeveloper added a commit to slinkydeveloper/knative-docs that referenced this pull request Jun 1, 2021
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@devguyio
Copy link
Contributor

devguyio commented Jun 1, 2021

/assign

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/feature/api_validation.go Do not exist 95.5%
pkg/apis/feature/features.go Do not exist 93.8%
pkg/apis/feature/store.go Do not exist 88.2%

Copy link
Contributor

@julz julz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm from a serving POV

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 1, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: julz, slinkydeveloper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 66dbf4a into knative:main Jun 1, 2021
@slinkydeveloper slinkydeveloper deleted the change_name_cm branch June 1, 2021 08:48
knative-prow-robot pushed a commit to knative/docs that referenced this pull request Jun 3, 2021
* Added the experimental features page

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Trailing whitespaces

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Added to the index

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* suggestion by julz

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* suggestion by ashleigh

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Reflected changes of knative/eventing#5459

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
RichardJJG pushed a commit to RichardJJG/docs that referenced this pull request Jun 30, 2021
* Added the experimental features page

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Trailing whitespaces

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Added to the index

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* suggestion by julz

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* suggestion by ashleigh

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Reflected changes of knative/eventing#5459

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
RichardJJG pushed a commit to RichardJJG/docs that referenced this pull request Jul 1, 2021
* Added the experimental features page

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Trailing whitespaces

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Added to the index

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* suggestion by julz

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* suggestion by ashleigh

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Reflected changes of knative/eventing#5459

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants