Skip to content

Modify experimental features e2e test setup#5479

Merged
knative-prow-robot merged 2 commits intoknative:mainfrom
slinkydeveloper:experimental_e2e_tests
Jun 9, 2021
Merged

Modify experimental features e2e test setup#5479
knative-prow-robot merged 2 commits intoknative:mainfrom
slinkydeveloper:experimental_e2e_tests

Conversation

@slinkydeveloper
Copy link
Contributor

@slinkydeveloper slinkydeveloper commented Jun 8, 2021

Signed-off-by: Francesco Guardiani francescoguard@gmail.com

See #5440 (comment) for more details

Proposed Changes

  • 🧹 Now experimental features main code doesn't modify the feature CM anymore, but the action does it instead

Pre-review Checklist

  • At least 80% unit test coverage: N/A
  • E2E tests for any new behavior: N/A
  • Docs PR for any user-facing impact: N/A
  • Spec PR for any new API feature: N/A
  • Conformance test for any change to the spec: N/A

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@knative-prow-robot knative-prow-robot added the area/test-and-release Test infrastructure, tests or release label Jun 8, 2021
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 8, 2021
@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 8, 2021
@codecov
Copy link

codecov bot commented Jun 8, 2021

Codecov Report

Merging #5479 (59b57b0) into main (ab3978c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5479   +/-   ##
=======================================
  Coverage   82.78%   82.78%           
=======================================
  Files         197      197           
  Lines        6093     6093           
=======================================
  Hits         5044     5044           
  Misses        724      724           
  Partials      325      325           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db83525...59b57b0. Read the comment docs.

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@slinkydeveloper
Copy link
Contributor Author

Works as expected: https://github.com/knative/eventing/pull/5479/checks?check_run_id=2771523236

That action step is executed only for experimental suite runs

Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 9, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, slinkydeveloper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [matzew,slinkydeveloper]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit a47f523 into knative:main Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants