Increase poll timings for IntegrationSource tests#8860
Merged
knative-prow[bot] merged 1 commit intoknative:mainfrom Jan 26, 2026
Merged
Increase poll timings for IntegrationSource tests#8860knative-prow[bot] merged 1 commit intoknative:mainfrom
knative-prow[bot] merged 1 commit intoknative:mainfrom
Conversation
The TestIntegrationSourceWithSinkRef and TestIntegrationSourceSendsEventsWithOIDC tests were timing out during cleanup when waiting for resources to be deleted. Added environment.WithPollTimings(5*time.Second, 4*time.Minute) to both tests to allow more time for resource cleanup, consistent with TestIntegrationSourceWithTLS which already had these timings configured. This prevents cleanup timeout failures: "magic.go:135: failed to wait for resources to be deleted: timed out waiting for the condition"
creydr
changed the title
knative-prow
bot
added
size/XS
knative-prow
bot
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Cali0707, creydr The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8860 +/- ##
=======================================
Coverage 51.15% 51.15%
=======================================
Files 409 409
Lines 21366 21366
=======================================
Hits 10930 10930
Misses 9584 9584
Partials 852 852 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
/test reconciler-tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The TestIntegrationSourceWithSinkRef and TestIntegrationSourceSendsEventsWithOIDC tests were timing out during cleanup when waiting for resources to be deleted (see here).
Increased the poll timeout in both tests to allow more time for resource cleanup, consistent with TestIntegrationSourceWithTLS which already had these timings configured.
This prevents cleanup timeout failures: