Lookup k8s services to ensure they exist#2149
Lookup k8s services to ensure they exist#2149knative-prow-robot merged 1 commit intoknative:mainfrom
Conversation
knative-prow-robot
added
the
kind/bug
knative-prow-robot
added
the
size/M
Codecov Report
@@ Coverage Diff @@
## main #2149 +/- ##
==========================================
+ Coverage 67.56% 67.60% +0.04%
==========================================
Files 215 215
Lines 9098 9098
==========================================
+ Hits 6147 6151 +4
+ Misses 2676 2674 -2
+ Partials 275 273 -2
Continue to review full report at Codecov.
|
|
Looks like we might be depending on this behavior in eventing tests |
| if err != nil { | ||
| return nil, apierrs.NewNotFound(gvr.GroupResource(), "Lister") | ||
| } | ||
|
|
||
| obj, err := lister.ByNamespace(ref.Namespace).Get(ref.Name) | ||
| if err != nil { | ||
| return nil, apierrs.NewNotFound(gvr.GroupResource(), ref.Name) | ||
| } | ||
|
|
There was a problem hiding this comment.
I know this code was here before but is there not a distinction between an error and object not found
There was a problem hiding this comment.
Yeah, always a bit odd to see a dropped err value
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: benmoss, vaikas The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
5 participants
Changes
/kind bug
Fixes knative/eventing#5442
Release Note