Skip to content

Adding 403 to the explictly defined codes#107

Merged
knative-prow[bot] merged 1 commit intoknative:mainfrom
matzew:draft_403_response_code
May 14, 2024
Merged

Adding 403 to the explictly defined codes#107
knative-prow[bot] merged 1 commit intoknative:mainfrom
matzew:draft_403_response_code

Conversation

@matzew
Copy link
Member

@matzew matzew commented Sep 12, 2023

Changes

  • Adding 403 response code explicitly, in case of "not allowed" events

/kind

Fixes #

Release Note


Docs


@knative-prow
Copy link

knative-prow bot commented Sep 12, 2023

@matzew: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

Details

In response to this:

Changes

  • Adding 403 response code explicitly, in case of "not allowed" events

/kind

Fixes #

Release Note


Docs


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 12, 2023
@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 12, 2023
@matzew matzew changed the title WIP: Adding 403 to the explictly defined codes Adding 403 to the explictly defined codes Nov 15, 2023
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 15, 2023
@knative-prow
Copy link

knative-prow bot commented Nov 15, 2023

@rajibmitra: changing LGTM is restricted to collaborators

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 1, 2024
@dprotaso
Copy link
Member

/assign @pierDipi

cc @matzew you'll need to rebase

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
@matzew matzew force-pushed the draft_403_response_code branch from 9df7691 to 3cb137c Compare April 30, 2024 06:48
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 30, 2024
@matzew
Copy link
Member Author

matzew commented Apr 30, 2024

@dprotaso I just rebased

@dprotaso
Copy link
Member

/approve

leaving lgtm for @pierDipi

@knative-prow
Copy link

knative-prow bot commented May 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, matzew, rajibmitra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2024
@pierDipi
Copy link
Member

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 14, 2024
@knative-prow knative-prow bot merged commit d78c7a6 into knative:main May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants