[10.x] Escape values before checking for their presence in HTML part of Mailables#42923
Merged
taylorotwell merged 1 commit intolaravel:masterfrom Jun 30, 2022
Merged
Conversation
turanjanin
force-pushed
the
fix-mailable-assertions
branch
from
99f389a to
3ec397b
Compare
turanjanin
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Laravel offers the ability to assert presence of a value inside the HTML for both views and mailables. However, the implementation of these assertions differ in a way that may cause confusion and occasional failing tests:
TestResponse::assertSee()escapes the HTML by default,Mailable::assertSeeInHtml()does not escape the HTML.This means that, for the same HTML,
$response->assertSee("O'Connor");will pass, while$mail->assertSeeInHtml("O'Connor");will fail.The goal of this PR is to align the behaviour of Mailable assertion methods with the rest of the similar assertion methods.