[12.x] Run Mockery cleanup via PHPUnit subscriber instead of explicit m::close() calls#58278
Merged
taylorotwell merged 7 commits intolaravel:12.xfrom Jan 5, 2026
Merged
Conversation
|
Thanks for submitting a PR! Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
added 7 commits
January 5, 2026 17:49
0696022 to
3b17674
Compare
m::close() calls
DarkGhostHunter
pushed a commit
to DarkGhostHunter/laravel-framework
that referenced
this pull request
Jan 5, 2026
… `m::close()` calls (laravel#58278) * Always alias Mockery with m * Fix tearDown visibility * Ensure tearDown methods always also call their parent::tearDown methods * No need to call m::close anymore * Drop useless tearDown methods * Use an extension instead of always closing Mockery * Apply StyleCI fix --------- Co-authored-by: Lucas Michot <lucas@zaiple.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR centralizes Mockery cleanup by registering a PHPUnit event subscriber that calls
Mockery::close()after each test method.As a result:
m::close()calls are removed from individual testsmaliasMotivation
Historically, many tests relied on manually calling
m::close()intearDown()or inline within test cases. This approach is:By moving cleanup to a PHPUnit subscriber, Mockery teardown becomes automatic, global, and uniform.
What changed
AfterTestMethodFinishedsubscriberMockery::close()after every testm::close()calls from testsmalias throughout the suiteBenefits
Notes