[12.x] Only fire composer uninstall events when removing dev packages#58338
Merged
taylorotwell merged 2 commits intolaravel:12.xfrom Jan 10, 2026
Merged
[12.x] Only fire composer uninstall events when removing dev packages#58338taylorotwell merged 2 commits intolaravel:12.xfrom
taylorotwell merged 2 commits intolaravel:12.xfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To close: #57613
There have been so many problems with this feature 😢 I hope that this clears up the last of them.
If we are uninstalling packages with the
--no-devflag, then we do not want to fire events. Why? Because it fixes a problem. Thinking further though, we wouldn't want these things to fire on production environments. That's not the intended use of this pattern. I misunderstood the naming of this eventprePackageUninstallthinking that it meant "when a package is requested to be removed from composer.json" instead of what it is, which is "when a package is being removed from your composer.lock"