[12.x] feat: allow queued listeners to be unique#58402
Merged
taylorotwell merged 1 commit intolaravel:12.xfrom Jan 28, 2026
Merged
[12.x] feat: allow queued listeners to be unique#58402taylorotwell merged 1 commit intolaravel:12.xfrom
taylorotwell merged 1 commit intolaravel:12.xfrom
Conversation
351c43a to
9ade44c
Compare
Member
|
@calebdw should we actually serialize the cache repository onto the queue in CallQueuedListener? Feels like that could cause issues with connections that can't be serialized, etc.? Any other options there? Just storing docs PR here for myself for reference: laravel/docs#10996 |
00b42f5 to
92b54e5
Compare
Contributor
Author
|
@taylorotwell, apologies for the delayed reply---I was without power for several days. Good catch on not serializing the cache, I was just following the job pattern without thinking too much 😅 I updated the CallQueuedListener to pass through to the listener method at runtime instead of serializing the property on the job |
ed575a2 to
4656cd9
Compare
4656cd9 to
5f9bc6c
Compare
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
This PR allows queued listeners to implement
ShouldBeUniqueandShouldBeUniqueUntilProcessing, similar to jobs. E.g,Motivation
I just had a bug in production where a listener was dispatched to the queue in rapid succession when it should not have been. Unfortunately, queued listeners could not implement the
ShouldBeUniqueandShouldBeUniqueUntilProcessingcontracts---they can only use theWithoutOverlappingmiddleware which prevents two jobs from running at the same time, but this does nothing to prevent duplicate jobs from being dispatched to the queue in the first place.Thanks!