[12.x] Fix Filesystem::sharedGet partial reads (#58418)#58419
Merged
taylorotwell merged 1 commit intolaravel:12.xfrom Jan 19, 2026
Merged
Conversation
Filesystem::sharedGet relied on a single fread() call to read the entire file. Since fread() may return fewer bytes than requested, this could result in truncated reads (often 8 KiB) even when the underlying file or stream contains more data. This change replaces the single fread() call with stream_get_contents() to ensure the entire stream is read, and adds a regression test using a custom stream wrapper that simulates partial reads. Fixes laravel#58418
sv63rus
force-pushed
the
fix/58418-filesystem-sharedget-partial-read
branch
from
7ed7909 to
e666280
Compare
sv63rus
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Filesystem::sharedGet relied on a single fread() call to read the entire file.
Since fread() may return fewer bytes than requested, this could result in truncated reads (often 8 KiB) even when the underlying file or stream contains more data.
This change replaces the single fread() call with stream_get_contents() to ensure the entire stream is read, and adds a regression test using a custom stream wrapper that simulates partial reads.
Fixes #58418