[12.x] add BatchFinished event#58431
Merged
taylorotwell merged 6 commits intolaravel:12.xfrom Jan 20, 2026
Merged
Conversation
|
Thanks for submitting a PR! Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
Contributor
Author
|
Failing test is PHP Stan freaking out about the ComponentTagCompiler.. same on main, so not related. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So, we have a BatchDispatched event, which we can hook into to find out when a batch was dispatched...
It would be nice to have a BatchFinished event too- that way we don't need to poll or even look at the DB to find out when its finished, and we can make it available for metrics / logging etc.
Why not just use the finally() callback?
Cause you have to remember to add it every time you create a batch, and if you're an infra man you just wanna see the metrics!
With this event you can listen for it globally and handle all batch completions in one place useful for logging, metrics, notifications etc.
Not sure if it's a 100% great fit in the Batch class, but didn't want to go into the repositories - so this seems to fit in with some other places.
Happy to move to 13.x if you deem risky 🫡