[12.x] Allow enum keys in Cache::flexible() and withoutOverlapping()#58444
Merged
taylorotwell merged 4 commits intolaravel:12.xfrom Jan 21, 2026
Merged
[12.x] Allow enum keys in Cache::flexible() and withoutOverlapping()#58444taylorotwell merged 4 commits intolaravel:12.xfrom
taylorotwell merged 4 commits intolaravel:12.xfrom
Conversation
|
Thanks for submitting a PR! Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
Contributor
Author
|
Failing due to PHPStan - same as main afaik. Shouldn't be related. |
This was referenced Jan 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Me again
Cache::flexible()andwithoutOverlapping()didn't support support enums, so adjusted / added tests for consistency with everything else.Also noticed two of the offset method docs were missing enum types, so added.
(Valuable if anyone is calling it directly I guess unlikely, but possible such as
Cache::driver('x')->offsetUnset(...))I think this now covers everything here enum wise.
Thanks