Add support for temporaryUploadUrl to the local filesystem#58499
Merged
taylorotwell merged 3 commits intolaravel:12.xfrom Feb 10, 2026
Merged
Add support for temporaryUploadUrl to the local filesystem#58499taylorotwell merged 3 commits intolaravel:12.xfrom
temporaryUploadUrl to the local filesystem#58499taylorotwell merged 3 commits intolaravel:12.xfrom
Conversation
This is heavily inspired from the `temporaryUrl` feature, but for uploads. Originally in https://github.com/mnapoli/laravel-local-temporary-upload-url
Contributor
|
I had a need for this the other day and because it wasn't available I had to setup minio 🤮. Thanks for adding this in! |
Contributor
|
Excellent! I think it's worth noting that there's a minor security issue since download and upload URLs are identical because they share the same URL pattern: Storage::put('receive-file-test.txt', 'Original Content');
$downloadUrl = Storage::temporaryUrl('receive-file-test.txt', now()->addMinute());
$response = $this->call('PUT', $downloadUrl, [], [], [], [], 'Malicious Content');
$response->assertNoContent();
$this->assertSame('Malicious Content', Storage::get('receive-file-test.txt'));That means anyone with a download URL can overwrite that file with a |
Contributor
Author
|
Ohh, I was certain the signature included the method (GET, PUT, etc.) I'm pushing a fix thanks 👍 |
Member
|
Thanks 👍 |
Contributor
Author
|
👯 thanks for merging! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is heavily inspired from the
temporaryUrlfeature, but applied for uploads.I also added support for
buildTemporaryUploadUrlsUsing(), that way temporary upload and download URLs have exactly the same features (for thelocalfilesystem).Background: https://github.com/mnapoli/laravel-local-temporary-upload-url and https://x.com/taylorotwell/status/2014899205295243592